Not all modding goes that far, but I do think you put well how many see it. I should also note that things like ALTTPR do not make money and are free for any to download and use with their own ROM (i.e. require that you own the game yourself). The are simply meant to add replayability and variety.
Re-arranging the items, varying the power/defense of enemies, etc. doesn’t seem to fit that case very well to me. There are, of course, mods that do a lot more than those are definitely more akin to what you wrote.
A lot aren’t going to have a huge opinion because easily-modded games aren’t a thing due to platform. PC gaming was always a very niche hobby here with most people not owning PCs. That has somewhat started to change recently, but that basically left other platforms where mods were either available (for free or paid) from the publisher or very difficult to go about at all as compared to modding common games on PC.
Based on my incredibly non-scientific “watching some stuff on youtube over the years” method, my money would be on Minecraft turning things around a bit as I did see Japanese creators playing a lot of modded minecraft on youtube.